Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

order retrieved events in SQLTrackerStore #4271

Merged
merged 2 commits into from
Aug 21, 2019
Merged

order retrieved events in SQLTrackerStore #4271

merged 2 commits into from
Aug 21, 2019

Conversation

r-m-n
Copy link
Contributor

@r-m-n r-m-n commented Aug 17, 2019

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tmbo tmbo requested a review from tabergma August 20, 2019 15:46
tabergma
tabergma approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for fixing this! I tested it locally and issue #4254 is solved using your solution. Thanks 🚀

@tabergma tabergma merged commit a560410 into RasaHQ:master Aug 21, 2019
@ricwo ricwo mentioned this pull request Sep 10, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabergma tabergma tabergma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postgres tracker store breaks formbot
3 participants
@r-m-n @CLAassistant @tabergma