Add glossary page #4297
Merged
Add glossary page #4297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akelad
reviewed
Aug 21, 2019
amn41
reviewed
Aug 25, 2019
amn41
reviewed
Aug 25, 2019
amn41
reviewed
Aug 25, 2019
amn41
reviewed
Aug 25, 2019
amn41
reviewed
Aug 25, 2019
amn41
reviewed
Aug 25, 2019
amn41
reviewed
Aug 25, 2019
amn41
reviewed
Aug 25, 2019
amn41
reviewed
Aug 25, 2019
amn41
reviewed
Aug 25, 2019
amn41
reviewed
Aug 25, 2019
|
thanks, @msamogh ! I think we need to make these definitions crystal clear, otherwise this page will hurt more than it helps. Happy to do an iteration in a google doc if that's quicker. Would be good to get @JustinaPetr input as well |
|
i'm also halfway through a review of this btw |
|
@amn41 We could collaborate on the definitions here (https://docs.google.com/spreadsheets/d/1v7xUaTYbhdIoR2q7hjYXqXzieB4z2zyqbjIzBleaBd8/edit#gid=0). I had copy-pasted several of them straight from the product team guide and simply added a few more onto that. I'll fix them in the sheet first and let's collaborate there before pushing things here? |
amn41
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)