Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow other origins to hit socketio #4303

Merged
merged 6 commits into from
Aug 23, 2019
Merged

allow other origins to hit socketio #4303

merged 6 commits into from
Aug 23, 2019

Conversation

akelad
Copy link
Contributor

@akelad akelad commented Aug 22, 2019 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@akelad akelad requested a review from wochinge August 22, 2019 16:18
wochinge
wochinge approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to update the change log. Could you please do it?

@wochinge
Copy link
Contributor

@akelad Updated the changelog

@akelad akelad merged commit 306491b into 1.2.x Aug 23, 2019
@Alexmhack Alexmhack mentioned this pull request Sep 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akelad @wochinge