Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more restructuring of the installation page #4357

Merged
merged 15 commits into from Sep 2, 2019
Merged

Conversation

msamogh
Copy link
Contributor

@msamogh msamogh commented Aug 30, 2019

Proposed changes:

  • Incorporate changes from user tests

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@msamogh msamogh marked this pull request as ready for review September 1, 2019 16:19
@msamogh msamogh changed the title Installation 1.2.x Incorporate changes from user tests Sep 1, 2019
@msamogh msamogh requested a review from amn41 September 1, 2019 16:20
@msamogh msamogh changed the title Incorporate changes from user tests Some more restructuring of the installation page Sep 1, 2019
Copy link
Contributor

@amn41 amn41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@msamogh msamogh merged commit eb80667 into 1.2.x Sep 2, 2019
@msamogh msamogh deleted the installation-1.2.x branch September 2, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants