Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXT: Ronancummins persist nlu training data option #4394

Merged
merged 7 commits into from Sep 4, 2019

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Sep 4, 2019

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ tmbo
✅ ronancummins
❌ Ronan Cummins


Ronan Cummins seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tmbo
Copy link
Member Author

tmbo commented Sep 4, 2019

doesn't need a review, #4388 has been reviewed

@tmbo tmbo added this to the Rasa 1.3 milestone Sep 4, 2019
@tmbo tmbo changed the title EXT Ronancummins persist nlu training data option EXT: Ronancummins persist nlu training data option Sep 4, 2019
@tmbo tmbo merged commit b364af2 into master Sep 4, 2019
@tmbo tmbo deleted the ronancummins-persist_nlu_training_data_option branch September 4, 2019 23:14
@vini-dixit
Copy link

Hi,
I have a question -
When we set persist_nlu_training_data=True in NLU training, where does the model get persisted?

I am trying below call-

rasa.train( domain=None, config=config, training_files=training_data, output=models_dir, fixed_model_name=model_name, persist_nlu_training_data=True )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants