Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid training CountVectorizer if no text is provided #4411

Closed
wants to merge 6 commits into from

Conversation

dakshvar22
Copy link
Contributor

Proposed changes:

  • Add a check for empty text list for a particular attribute before calling the fit function on CountVectorizer object.
  • Train method only logs a warning now if some text is provided for an attribute, but still .fit() throws an exception.

Status (please check what you already did):

  • made PR ready for code review
  • reformat files using black (please check Readme for instructions)

@dakshvar22 dakshvar22 requested a review from tmbo September 6, 2019 14:26
@tmbo
Copy link
Member

tmbo commented Sep 9, 2019

You branched of from master. please create a fresh branch from 1.3.x and cherry pick your commits to that branch. please open a new PR afterwards.

should be along the lines of

git checkout 1.3.x
git checkout -b bug-fix-count-vector-logging
git cherry-pick ebf556e

@tmbo tmbo closed this Sep 9, 2019
@tmbo tmbo added the invalid label Sep 9, 2019
@dakshvar22
Copy link
Contributor Author

@tmbo My bad. I think I did branch from 1.3.x but accidentally merged master into it. Will open a new PR.

@dakshvar22 dakshvar22 deleted the bug-fix-cv_logging branch September 10, 2019 16:16
@tmbo tmbo added resolution:wontfix issue is acknowledged but we will not work on this (nor will we accept contributions) and removed invalid labels Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:wontfix issue is acknowledged but we will not work on this (nor will we accept contributions)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants