Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix after-deploy Slack script #4429

Merged
merged 3 commits into from Sep 10, 2019
Merged

Fix after-deploy Slack script #4429

merged 3 commits into from Sep 10, 2019

Conversation

federicotdn
Copy link
Contributor

Proposed changes:

  • Fix the release notice Slack script.

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

tmbo
tmbo approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 🚀

can you please fork from 1.3.x and cherry pick these changes there? base branch of pr should be 1.3.x as well

scripts/ping_slack_about_package_release.sh Outdated Show resolved Hide resolved
@federicotdn federicotdn merged commit 5b7ca74 into master Sep 10, 2019
@federicotdn federicotdn mentioned this pull request Sep 11, 2019
Merged
5 tasks
@tmbo tmbo deleted the slack-script branch October 28, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@federicotdn @tmbo