use sender id from message object from permitted users #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wochinge
force-pushed
the
interactive-learning-arbitrary-ids
branch
from
8501f45
to
c7adcf9
Compare
gausie
reviewed
Sep 20, 2019
gausie
reviewed
Sep 20, 2019
rasa/core/channels/rasa_chat.py
Outdated
| ): | ||
| return req.json["conversation_id"] | ||
| else: | ||
| return jwt_payload["username"] |
There was a problem hiding this comment.
This will send the message to the user's own conversation if they choose a conversation_id but don't have the correct permission, rather than giving a 401 as it probably should.
wochinge
force-pushed
the
interactive-learning-arbitrary-ids
branch
from
93e0f30
to
eafb5d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)