Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure CORS on server without api #4521

Merged
merged 8 commits into from
Sep 26, 2019
Merged

configure CORS on server without api #4521

merged 8 commits into from
Sep 26, 2019

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Sep 25, 2019

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@erohmensing erohmensing changed the base branch from master to 1.3.x September 25, 2019 15:52
@erohmensing erohmensing changed the title add cors config to app without api configure CORS on server without api Sep 25, 2019
@erohmensing
Copy link
Contributor Author

@wochinge Tested this locally -- before, it worked with the flag and didn't work without, and after, it worked with both. Let me know if you have ideas for a more proper way of testing this!

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that! However, let's re-use the cors stuff between the different configure_apps

CHANGELOG.rst Outdated Show resolved Hide resolved
rasa/core/run.py Outdated Show resolved Hide resolved
erohmensing and others added 2 commits September 25, 2019 18:15
Co-Authored-By: Tobias Wochinger <t.wochinger@rasa.com>
rasa/core/run.py Show resolved Hide resolved
rasa/server.py Outdated Show resolved Hide resolved
rasa/server.py Outdated Show resolved Hide resolved
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

rasa/core/run.py Outdated Show resolved Hide resolved
rasa/core/run.py Outdated Show resolved Hide resolved
rasa/core/run.py Outdated Show resolved Hide resolved
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

erohmensing and others added 2 commits September 26, 2019 09:36
Co-Authored-By: Tobias Wochinger <t.wochinger@rasa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants