Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RabbitMQ app_id message property #4715

Merged
merged 8 commits into from Nov 4, 2019
Merged

RabbitMQ app_id message property #4715

merged 8 commits into from Nov 4, 2019

Conversation

ricwo
Copy link
Contributor

@ricwo ricwo commented Nov 2, 2019

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@ricwo ricwo requested a review from wochinge November 2, 2019 09:25
wochinge
wochinge approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and nice test! Left one question.

rasa/core/brokers/pika.py Show resolved Hide resolved
rasa/core/brokers/pika.py Outdated Show resolved Hide resolved
@ricwo @wochinge
Update rasa/core/brokers/pika.py
e57760c 
Co-Authored-By: Tobias Wochinger <t.wochinger@rasa.com>
@ricwo ricwo merged commit b477eb9 into 1.4.x Nov 4, 2019
@ricwo ricwo deleted the rabbit-app-id-property branch November 4, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ricwo @wochinge