Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use only word level featurizer for intents #4743

Merged
merged 4 commits into from Nov 8, 2019
Merged

use only word level featurizer for intents #4743

merged 4 commits into from Nov 8, 2019

Conversation

Ghostvv
Copy link
Contributor

@Ghostvv Ghostvv commented Nov 8, 2019 •
edited

Proposed changes:

  • use only word level featurizer for intents

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@Ghostvv Ghostvv requested a review from tabergma November 8, 2019 14:41
tabergma
tabergma approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ghostvv Ghostvv merged commit 5c6a6e9 into master Nov 8, 2019
@Ghostvv Ghostvv deleted the fix_intent_featurizer branch November 8, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabergma tabergma tabergma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ghostvv @tabergma