Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use futurewarnings for end user deprecation warnings #4861

Merged
merged 2 commits into from Nov 27, 2019
Merged

use futurewarnings for end user deprecation warnings #4861

merged 2 commits into from Nov 27, 2019

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Nov 27, 2019 •
edited

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

tabergma
tabergma approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erohmensing erohmensing mentioned this pull request Nov 27, 2019
Merged
5 tasks
@erohmensing erohmensing merged commit 5ddc961 into 1.5.x Nov 27, 2019
@erohmensing erohmensing deleted the deprecation branch November 27, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabergma tabergma tabergma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erohmensing @tabergma