Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update choosing-a-pipeline.rst #4869

Merged
merged 4 commits into from Dec 6, 2019
Merged

Update choosing-a-pipeline.rst #4869

merged 4 commits into from Dec 6, 2019

Conversation

rgstephens
Copy link
Contributor

@rgstephens rgstephens commented Nov 27, 2019

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added "close #4867" to the description for auto-closing purposes.

.gitignore Outdated Show resolved Hide resolved
@erohmensing
Copy link
Contributor

Actually, please rebase to 1.5.x and also add a changelog file :)

@tmbo tmbo changed the base branch from master to 1.5.x December 4, 2019 13:53
.gitignore Outdated Show resolved Hide resolved
@tmbo tmbo merged commit 0151e24 into 1.5.x Dec 6, 2019
@tmbo tmbo deleted the convert-pipeline-doc branch December 6, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants