Deprecate inline lookup tables #4871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rasa X does not support inline lookup tables. To be consistent these are also deprecated in ``rasa``.
|
wait, I should also update the docs. Gonna do that in a sec. |
federicotdn
approved these changes
Dec 4, 2019
docs/nlu/training-data-format.rst
Outdated
| @@ -67,7 +62,9 @@ learn the domain with fewer examples and also help it be more confident of its p | |||
| Synonyms will map extracted entities to the same name, for example mapping "my savings account" to simply "savings". | |||
| However, this only happens *after* the entities have been extracted, so you need to provide examples with the synonyms present so that Rasa can learn to pick them up. | |||
|
|
|||
| Lookup tables may be specified either directly as lists or as txt files containing newline-separated words or phrases. Upon loading the training data, these files are used to generate case-insensitive regex patterns that are added to the regex features. For example, in this case a list of currency names is supplied so that it is easier to pick out this entity. | |||
| Lookup tables may be specified as txt files containing newline-separated words or | |||
There was a problem hiding this comment.
Would change txt for plain text
Co-Authored-By: Federico Tedin <federicotdn@users.noreply.github.com>
…sa into deprecate-inline-lookup-tables
|
I guess this should go into the minor next week as well? |
|
yes |
|
So how exactly should these look like now? Also, do you support multiple files per lookup? |
|
Hi @cristianmtr , multiple files per lookup currently don't work. The lookup files should be provided as described in the documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)