Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max_history example #4872

Merged
merged 1 commit into from Nov 29, 2019
Merged

Fix max_history example #4872

merged 1 commit into from Nov 29, 2019

Conversation

akelad
Copy link
Contributor

@akelad akelad commented Nov 28, 2019

Proposed changes:

  • Fix small but important max history mistake

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cause it needs to see that there were 2 utter_defaults right?

Also, I think Tom will make you make a changelog file for this 😄

@akelad
Copy link
Contributor Author

akelad commented Nov 29, 2019

idk, does a docs change like this require a changelog entry? also yes correct, as soon as you have another intent that triggers utter_default, you would need the max history be 5 as well

@erohmensing
Copy link
Contributor

Ah yeah okay that makes sense, that's why i was a bit confused. And i guess the instructions say docs one are for new docs or big reworkings, so i suppose not

@erohmensing erohmensing merged commit 52b28eb into 1.5.x Nov 29, 2019
@erohmensing erohmensing deleted the fix-max-history branch November 29, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants