Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add socket logging libraries to set_log_level #4915

Merged
merged 3 commits into from Dec 9, 2019
Merged

add socket logging libraries to set_log_level #4915

merged 3 commits into from Dec 9, 2019

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Dec 6, 2019 •
edited

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@erohmensing erohmensing changed the title add socket logging libraries to log_level_libraries add socket logging libraries to set_log_level Dec 6, 2019
akelad
akelad approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@akelad akelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@erohmensing erohmensing merged commit b2c2237 into 1.5.x Dec 9, 2019
@erohmensing erohmensing deleted the socket-logs branch December 9, 2019 08:55
@erohmensing erohmensing mentioned this pull request Feb 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akelad akelad akelad approved these changes

@tabergma tabergma Awaiting requested review from tabergma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erohmensing @akelad