Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong link to endpoint #4945

Merged
merged 2 commits into from Dec 11, 2019
Merged

fix wrong link to endpoint #4945

merged 2 commits into from Dec 11, 2019

Conversation

TyDunn
Copy link
Contributor

@TyDunn TyDunn commented Dec 11, 2019

Community member pointed out that link to the endpoint does not work. It is because of the .html after http-api. The current link works when you run make livehtml; however, it does not work when the docs are deployed on rasa.com/docs. Not sure how to make sure my change works

Proposed changes:

  • ...

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

Community member pointed out that link to the endpoint does not work. It is because of the `.html` after `http-api`. The current link works when you run `make livehtml`; however, it does not work when the docs are deployed on `rasa.com/docs`. Not sure how to make sure my change works
@TyDunn TyDunn requested a review from akelad December 11, 2019 13:22
Copy link
Contributor

@akelad akelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@tmbo tmbo merged commit 3335c6e into master Dec 11, 2019
@tmbo tmbo deleted the fix-wrong-endpoint-linkdoc-link branch December 11, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants