Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user ID always default on every shell session. #5117

Merged
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
08eda89
Fix user ID always default on every shell session.
VictorCoCo Jan 23, 2020
4eda4ed
add changelog record.
VictorCoCo Jan 26, 2020
7d093a8
Update rasa/core/channels/console.py
VictorCoCo Jan 26, 2020
984c702
Update rasa/core/channels/console.py
VictorCoCo Jan 26, 2020
1622793
Update rasa/core/channels/console.py
VictorCoCo Jan 26, 2020
0034e33
Update changelog/5117.improvement.rst
VictorCoCo Jan 26, 2020
a5b185c
Update changelog/5117.improvement.rst
VictorCoCo Jan 26, 2020
3dee8fd
Merge branch 'master' into fix-user-id-always-default-on-shell-session
ricwo Jan 28, 2020
88a3c09
Merge branch 'master' into fix-user-id-always-default-on-shell-session
ricwo Jan 29, 2020
cc2f1cc
Merge branch 'master' into fix-user-id-always-default-on-shell-session
ricwo Jan 29, 2020
bf9945e
Merge branch 'master' into fix-user-id-always-default-on-shell-session
ricwo Jan 30, 2020
a1351f5
Fix rasa core channels test.
VictorCoCo Jan 30, 2020
529c2e9
Add --sender-id argument to rasa shell.
VictorCoCo Feb 3, 2020
6c93b3f
Change sell --sender-id argument name to --conversation-id
VictorCoCo Feb 3, 2020
af2b561
Adjust rasa shell help test to changes.
VictorCoCo Feb 6, 2020
2f40740
Merge branch 'master' into fix-user-id-always-default-on-shell-session
ricwo Feb 6, 2020
cc76148
Add new line at the end of rasa consts file.
VictorCoCo Feb 9, 2020
0bc6078
Merge branch 'master' into fix-user-id-always-default-on-shell-session
ricwo Feb 9, 2020
368efe6
Remove unnecessary line at the end of the rasa constants.
VictorCoCo Feb 9, 2020
a148933
Fix channels test format.
VictorCoCo Feb 9, 2020
0397e4d
Reformat rasa cli shell.py
VictorCoCo Feb 9, 2020
dd52f11
Update rasa/cli/shell.py
VictorCoCo Feb 10, 2020
d0115ab
Update rasa/cli/shell.py
VictorCoCo Feb 10, 2020
c5fb40c
Change changelog record according to the new changes.
VictorCoCo Feb 10, 2020
ec6590e
Use const as default --conversation-id argument value.
VictorCoCo Feb 10, 2020
f50d0c0
Update rasa/core/channels/console.py
VictorCoCo Feb 10, 2020
b7ab04d
Update rasa/core/run.py
VictorCoCo Feb 10, 2020
cc5e7b7
Update rasa/core/run.py
VictorCoCo Feb 10, 2020
af501c7
Update rasa/core/run.py
VictorCoCo Feb 10, 2020
f01166c
Update rasa/core/run.py
VictorCoCo Feb 10, 2020
2104ec3
Update rasa/core/channels/console.py
VictorCoCo Feb 10, 2020
63fcf89
Fix unresolved reference for UserMessage.
VictorCoCo Feb 10, 2020
823379a
Merge branch 'master' into fix-user-id-always-default-on-shell-session
ricwo Feb 11, 2020
d2454b0
Update changelog/5117.improvement.rst
VictorCoCo Feb 11, 2020
927a272
Update changelog/5117.improvement.rst
VictorCoCo Feb 11, 2020
bd38b69
Merge branch 'master' into fix-user-id-always-default-on-shell-session
ricwo Feb 14, 2020
f4cd9e8
Merge branch 'master' into fix-user-id-always-default-on-shell-session
ricwo Feb 18, 2020
32be2b3
Merge branch 'master' into fix-user-id-always-default-on-shell-session
tmbo Feb 21, 2020
ecf01b6
Change --coversation-id to be random by default.
VictorCoCo Feb 23, 2020
ea75052
Add conversation_id arg to interactive test.
VictorCoCo Feb 23, 2020
b1d32cb
Add default conversation id value on core.run functions.
VictorCoCo Feb 23, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog/5117.improvement.rst
@@ -0,0 +1,2 @@
New user ID will be generated for each shell session.
VictorCoCo marked this conversation as resolved.
Show resolved Hide resolved
Previously the user ID was always 'default'.
VictorCoCo marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 2 additions & 2 deletions rasa/core/channels/console.py
@@ -1,5 +1,6 @@
# this builtin is needed so we can overwrite in test
import json
import uuid
VictorCoCo marked this conversation as resolved.
Show resolved Hide resolved
import logging
import asyncio
from typing import Text, Optional, Dict, List
Expand All @@ -12,7 +13,6 @@
from rasa.cli import utils as cli_utils
from rasa.core import utils
from rasa.core.channels.channel import RestInput
from rasa.core.channels.channel import UserMessage
from rasa.core.constants import DEFAULT_SERVER_URL
from rasa.core.interpreter import INTENT_MESSAGE_PREFIX
from rasa.utils.io import DEFAULT_ENCODING
Expand Down Expand Up @@ -111,7 +111,7 @@ async def send_message_receive_stream(
async def record_messages(
server_url=DEFAULT_SERVER_URL,
auth_token="",
sender_id=UserMessage.DEFAULT_SENDER_ID,
sender_id=uuid.uuid4().hex,
VictorCoCo marked this conversation as resolved.
Show resolved Hide resolved
max_message_limit=None,
use_response_stream=True,
) -> int:
Expand Down