add RabbitMQ message header to "rasa export" #5318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricwo
commented
Feb 25, 2020
ricwo
commented
Feb 25, 2020
ricwo
commented
Feb 25, 2020
wochinge
approved these changes
Feb 26, 2020
| `PikaEventBroker`, else `None`. | ||
|
|
||
| """ | ||
| if isinstance(self.event_broker, (PikaEventBroker, PikaProducer)): |
There was a problem hiding this comment.
optional: you could use issubclass and just check against PikaEventBroker which would be a tiny bit more robust
|
|
||
| """ | ||
| if isinstance(self.event_broker, (PikaEventBroker, PikaProducer)): | ||
| return {RASA_EXPORT_PROCESS_ID_HEADER_NAME: uuid.uuid4().hex} |
There was a problem hiding this comment.
optional: we could also just have this constant at the top of the this module since it's not used anywhere else
There was a problem hiding this comment.
ah, you're using this in Rasa X? Then it makes sense to have this in rasa.core.constants
|
|
||
| """ | ||
| if isinstance(self.event_broker, (PikaEventBroker, PikaProducer)): | ||
| self.event_broker.publish(event=event, headers=headers) |
There was a problem hiding this comment.
optional: Should we make the headers an attribute so that we don't have different signatures? Also, I guess the headers wouldn't change between messages, right?
|
Ok, just saw the telemetry issue. Then my questions are answered 👍 Good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
rasa export#5317Status (please check what you already did):
black(please check Readme for instructions)