-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish to multiple RabbitMQ queues #5387
Merged
Merged
Changes from 21 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
deeea72
multiple queues
ricwo b9440f8
f-strings
ricwo 18da7c9
Merge branch 'master' into multiple-queues
ricwo 295f314
newlines
ricwo 4760a89
remove newline
ricwo 2113a26
fix tests
ricwo 36dcca6
types
ricwo bb59514
fix docstrings
ricwo 64a1024
Merge branch 'master' into multiple-queues
ricwo 3c9a615
deprecate `queue` parameter
ricwo 6aa561b
fix warnings
ricwo 478cc15
fix test
ricwo 4b35f81
Merge branch 'master' into multiple-queues
ricwo eca4d9c
test warnings
ricwo 3e83887
Merge branch 'master' into multiple-queues
ricwo 6581f12
indent
ricwo a2e68fa
review
ricwo 280c4af
Merge branch 'master' into multiple-queues
ricwo 26ae27c
rename default queue
ricwo 873d344
fix deepsource issues
ricwo 1e52625
Merge branch 'master' into multiple-queues
ricwo cb72779
rewrite docstring
ricwo f2c0a8d
move attributes to __init__ docstring
ricwo 05e0dc2
durable queue
ricwo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
Added ``PikaEventBroker`` (:ref:`event-brokers-pika`) support for publishing to | ||
multiple queues. Messages are now published to a ``fanout`` exchange with name | ||
``rasa-exchange`` (see | ||
`here <https://www.rabbitmq.com/tutorials/amqp-concepts.html#exchange-fanout>`_ | ||
for more information on ``fanout`` exchanges). | ||
|
||
The former ``queue`` key is deprecated. Queues should now be | ||
specified as a list in the ``endpoints.yml`` event broker config under a new key | ||
``queues``. Example config: | ||
|
||
.. code-block:: yaml | ||
|
||
event_broker: | ||
type: pika | ||
url: localhost | ||
username: username | ||
password: password | ||
queues: | ||
- queue-1 | ||
- queue-2 | ||
- queue-3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
event_broker: | ||
type: pika | ||
url: localhost | ||
username: username | ||
password: password | ||
queue: queue | ||
type: pika | ||
queues: | ||
- queue-1 | ||
# you may supply more than one queue to publish to | ||
# - queue-2 | ||
# - queue-3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's better add this to the changelog. Could be that some people build on this default value 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or is this only changed in the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I deliberately only changed it in the docs for now - we still have
rasa_core_events
as the default for backwards compatibility. maybe update this in 2.0?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good 👍 Should we create an issue for this?