Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on components.rst #5410

Merged
merged 25 commits into from Mar 20, 2020
Merged

Updates on components.rst #5410

merged 25 commits into from Mar 20, 2020

Conversation

tabergma
Copy link
Contributor

@tabergma tabergma commented Mar 11, 2020

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tabergma tabergma marked this pull request as ready for review March 11, 2020 16:44
@tabergma
Copy link
Contributor Author

I would recommend to checkout the branch and build the docs (e.g. make livedocs) otherwise it is hard to see how the toggle actual works.

docs/nlu/components.rst Show resolved Hide resolved
docs/nlu/components.rst Outdated Show resolved Hide resolved
docs/nlu/components.rst Outdated Show resolved Hide resolved
docs/nlu/components.rst Outdated Show resolved Hide resolved
docs/nlu/components.rst Outdated Show resolved Hide resolved
docs/nlu/components.rst Outdated Show resolved Hide resolved
docs/nlu/components.rst Outdated Show resolved Hide resolved
docs/nlu/components.rst Outdated Show resolved Hide resolved
docs/nlu/components.rst Outdated Show resolved Hide resolved
docs/nlu/components.rst Outdated Show resolved Hide resolved
@Ghostvv Ghostvv requested a review from koaning March 11, 2020 17:05
@Ghostvv
Copy link
Contributor

Ghostvv commented Mar 11, 2020

@tabergma I'd also add weight_sparsity for people to change

@tabergma
Copy link
Contributor Author

@erohmensing @ArjaanBuijk Any feedback?

@tabergma tabergma changed the base branch from 1.8.x to master March 18, 2020 09:12
@tabergma tabergma changed the base branch from master to 1.8.x March 18, 2020 09:14
@tabergma tabergma changed the base branch from 1.8.x to master March 19, 2020 16:45
Co-Authored-By: Arjaan Buijk <a.buijk@rasa.com>
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you! My only major qualm is that right now, it's not obvious that there is something to expand, but maybe that's something with my livedocs setup

docs/nlu/components.rst Outdated Show resolved Hide resolved
docs/nlu/components.rst Outdated Show resolved Hide resolved
docs/nlu/components.rst Show resolved Hide resolved
docs/nlu/components.rst Show resolved Hide resolved
docs/nlu/components.rst Outdated Show resolved Hide resolved
docs/nlu/components.rst Outdated Show resolved Hide resolved
docs/nlu/components.rst Outdated Show resolved Hide resolved
docs/nlu/components.rst Outdated Show resolved Hide resolved
docs/nlu/components.rst Outdated Show resolved Hide resolved
docs/_static/css/custom.css Show resolved Hide resolved
tabergma and others added 3 commits March 20, 2020 10:44
Co-Authored-By: Ella Rohm-Ensing <erohmensing@gmail.com>
Co-Authored-By: Ella Rohm-Ensing <erohmensing@gmail.com>
Co-Authored-By: Ella Rohm-Ensing <erohmensing@gmail.com>
@Ghostvv Ghostvv added this to the Rasa 1.9 milestone Mar 20, 2020
@tabergma tabergma merged commit 39079ee into master Mar 20, 2020
@tabergma tabergma deleted the docs-nlu-components branch March 25, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants