Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix double assignment #5428

Merged
merged 4 commits into from Mar 18, 2020
Merged

fix double assignment #5428

merged 4 commits into from Mar 18, 2020

Conversation

Ghostvv
Copy link
Contributor

@Ghostvv Ghostvv commented Mar 17, 2020

Proposed changes:

  • ...

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Ghostvv Ghostvv requested a review from tabergma March 17, 2020 14:19
@tttthomasssss
Copy link
Contributor

@Ghostvv @tabergma is this ready to go into 1.9.0?

@tabergma tabergma merged commit f3a3fb7 into master Mar 18, 2020
@Ghostvv Ghostvv deleted the Ghostvv-patch-1 branch March 24, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants