Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs removal #5650

Merged
merged 8 commits into from Apr 22, 2020
Merged

docs removal #5650

merged 8 commits into from Apr 22, 2020

Conversation

koaning
Copy link
Contributor

@koaning koaning commented Apr 16, 2020

Proposed changes:

@akelad like we discussed in slack, this part of the docs will now be removed will be added later, after review, to the blog.

@amn41 @dakshvar22 pinging you here such that you're also aware of the change.

@koaning koaning added the type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones. label Apr 16, 2020
@akelad
Copy link
Contributor

akelad commented Apr 16, 2020

i guess you meant to request a review from me rather than assign right?

@koaning
Copy link
Contributor Author

koaning commented Apr 16, 2020

@akelad yes, my bad.

i think i forgot to remove the bert link in the doc index, pushing commit now.

@koaning koaning requested a review from akelad April 16, 2020 21:31
@koaning
Copy link
Contributor Author

koaning commented Apr 17, 2020

@akelad there seems to be an issue with a docker container not building.

Building rasa (1.9.5)
 - Building wheel
 - Built rasa-1.9.5-py3-none-any.whl
Processing ./dist/rasa-1.9.5-py3-none-any.whl
Installing collected packages: rasa
Successfully installed rasa-1.9.5
WARNING: You are using pip version 19.3.1; however, version 20.0.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Error processing tar file(exit status 1): write /root/.cache/pip/http/d/9/c/c/b/d9ccb85290d9889b7fd067a45d9cd98ce7bcd4ee2d66f167f5e940c2: no space left on device

##[error]Process completed with exit code 1.

I am restarting the jobs just to be sure.

@koaning
Copy link
Contributor Author

koaning commented Apr 18, 2020

@akelad I'd love to click that merge button but CI is showing weird things since your indentation commit.

image

The tests fail but I am unable to expand it to see what is in there. I'll hit re-run just in case.

@akelad akelad merged commit c82fc41 into master Apr 22, 2020
@akelad akelad deleted the remove-bert branch April 22, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants