Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change defaults in EmbeddingIntentClassifier and DIETClassifier #5717

Merged
merged 9 commits into from
Apr 27, 2020
Merged

Change defaults in EmbeddingIntentClassifier and DIETClassifier #5717

merged 9 commits into from
Apr 27, 2020

Conversation

dakshvar22
Copy link
Contributor

@dakshvar22 dakshvar22 commented Apr 24, 2020 •
edited
Loading

Proposed changes:

  • Use scale_loss=False in DIETClassifier
  • Reduce the dense dimension size for sparse features to 256 in EmbeddingIntentClassifier
  • Tested with different configs on 5 datasets.

Status (please check what you already did):

  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@dakshvar22 dakshvar22 added this to the 1.10 Rasa Open Source milestone Apr 24, 2020
@akelad akelad removed their request for review April 27, 2020 07:07
@dakshvar22 dakshvar22 requested a review from Ghostvv April 27, 2020 09:26
@dakshvar22 dakshvar22 merged commit 81bcc8a into master Apr 27, 2020
@dakshvar22 dakshvar22 deleted the change_defaults branch April 27, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ghostvv Ghostvv Ghostvv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10 Rasa Open Source
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dakshvar22 @Ghostvv