Move actions.py -> actions/actions.py in rasa init #6611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erohmensing
approved these changes
Sep 10, 2020
Comment on lines
-169
to
-179
| Start by creating the custom actions in a directory `actions` in your working directory: | ||
|
|
||
| ```bash | ||
| mkdir actions | ||
| mv actions.py actions/actions.py | ||
| # Rasa SDK expects a python module. | ||
| # Therefore, make sure that you have this file in the directory. | ||
| touch actions/__init__.py | ||
| ``` | ||
|
|
||
| Then build a custom action using the Rasa SDK by editing `actions/actions.py`, for example: |
|
|
||
| The `rasa/rasa-sdk` image will automatically look for the actions in `actions/actions.py`. | ||
| 1. Make sure your actions are defined in `actions/actions.py`. The `rasa/rasa-sdk` | ||
| image will automatically look for the actions in this file. |
There was a problem hiding this comment.
Just a thought, can you provide multiple actions files? If so it probably makes sense to update rasa sdk to pass the directory instead of that specific path to the module 🤔
There was a problem hiding this comment.
but we're using DEFAULT_ACTIONS_PATH which is just actions, so Rasa SDK will by default load the whole actions package
There was a problem hiding this comment.
sorry, should have clarified, i meant in the dockerfile: https://github.com/RasaHQ/rasa-sdk/blob/master/Dockerfile#L40
There was a problem hiding this comment.
aah got it, good point! we should change that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)