Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack init message #7368

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Slack init message #7368

wants to merge 11 commits into from

Conversation

koszta5
Copy link

@koszta5 koszta5 commented Nov 25, 2020

Proposed changes:

  • Allow slack channel to support welcome message pattern by forwarding to init intent automatically when a user interaction with chatbot starts
  • fixes Slack Welcome message #7366
    Status (please check what you already did):
  • [] added some tests for the functionality
  • [✅] updated the documentation
  • [✅ ] updated the changelog (please check changelog for instructions)
  • [✅] reformat files using black (please check Readme for instructions)

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2020

CLA assistant check
All committers have signed the CLA.

@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @rgstephens will take a look at it as soon as possible ✨

Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution. After thinking about it, I am not sure we should put the burden of figuring out if this really is an "init" on the user.

We already have the session_started event that we emit if a new conversation is started which you can react to in a custom action and take things from there - I am not sure what different use case this would be used for, can you add some thoughts?

@koszta5
Copy link
Author

koszta5 commented Dec 11, 2020

hi @tmbo - yes I m aware of that. But you are kind of proving my point by your reply.

we have session_started event that we emit if a new conversation is started
If you read the article that I provided (and I can provide more as a proof) the good default behavior of chatbot should be that it actively send the 1st message to user.

Which current solution using session_started is incapable of. This solution will only react to user's first message. Which is putting the burden on user having him/her understand what the chatbot can do or having to ask the obvious question what can you do for me?

The burden of having to figure out the "init" of the user is not that hard. Bottom line - this behavior is optional and this fact is clearly documented in changed doc files.

@rgstephens rgstephens removed their request for review December 30, 2020 18:43
Base automatically changed from master to main January 22, 2021 11:15
@koszta5 koszta5 mentioned this pull request Feb 16, 2021
@akelad
Copy link
Contributor

akelad commented Feb 17, 2021

@tmbo any updates on this? :D

@tmbo
Copy link
Member

tmbo commented Feb 17, 2021

I agree that there is a use case for this and that it is earlier than what we currently call "SessionStarted". I do think that we need a more general approach to this though, that works across channels.

I don't think using a special intent is the right approach for this for different reasons:

  • you'd be able to create stories that start with init and some that don't, but what is the difference?
  • to generalize this and to be able to get access to as much information about the user as possible, you'd want to have access to more meta information when writing this initial message. You might want to look up the user in a DB and respond with user-specific information, e.g. "Hey there Sara, you got 3 bills awaiting payment, do you want me to make a transfer?"
  • backwards-incompatible (at least in its current implementation)

I think we should at least think about more generalisable/alternative approaches to support this use case, e.g.

  • add an event that gets triggered before a user initializes a conversation, on chat window open
  • move the sessionstarted event to get triggered earlier

@koszta5
Copy link
Author

koszta5 commented Feb 18, 2021

@tmbo - I like your ideas - they make sense to me.

I think we should at least think about more generalisable/alternative approaches to support this use case, e.g.

  • add an event that gets triggered before a user initializes a conversation, on chat window open
  • move the sessionstarted event to get triggered earlier

which of those 2 makes more sense from your point of view? I could understand both but maybe for the purpose of compatibility there could be a new event called sessioninitiated?

Something like that? When I get some time I would look into it and try to implement this (I hope that I find the right place in code :P )

@stale
Copy link

stale bot commented Apr 16, 2022

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@tmbo tmbo requested a review from a team as a code owner September 12, 2022 19:48
@tmbo tmbo requested review from sanchariGr and removed request for a team September 12, 2022 19:48
@stale stale bot removed stale labels Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack Welcome message
5 participants