Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading the data in core test with TrainingDataImporter interface #7795

Merged
merged 13 commits into from
Jan 27, 2021

Conversation

Imod7
Copy link
Contributor

@Imod7 Imod7 commented Jan 25, 2021

Proposed changes:
Using the TrainingDataImporter to load the data in core test.

[The current PR is a continuation of this PR where I did something wrong with the commits/rebase/merge and it is quite difficult to clean it up so I created a new PR, the current one, with all changes in a new/clean branch].

Note
It is the proposed solution for the 1st part of this Issue #5986.
The 2nd part was solved from this PR.

@Imod7 Imod7 linked an issue Jan 25, 2021 that may be closed by this pull request
1 task
@Imod7 Imod7 added the tools:clear-poetry-cache-unit-tests Clear poetry cache for the unit tests label Jan 25, 2021
@Imod7 Imod7 requested a review from wochinge January 25, 2021 12:46
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the new PR!

We also need a changelog entry for this.

rasa/shared/data.py Outdated Show resolved Hide resolved
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems it's time to convert from draft to ready for review 💯

changelog/5986.improvement.md Outdated Show resolved Hide resolved
@Imod7 Imod7 marked this pull request as ready for review January 26, 2021 16:40
@Imod7 Imod7 requested a review from wochinge January 26, 2021 17:48
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work wrapping this up 💯

changelog/5986.improvement.md Outdated Show resolved Hide resolved
@Imod7 Imod7 merged commit 8e68e39 into main Jan 27, 2021
@Imod7 Imod7 deleted the trainingdataimporter-core branch January 27, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools:clear-poetry-cache-unit-tests Clear poetry cache for the unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rasa test should use TrainingDataImporter
2 participants