-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading the data in core test with TrainingDataImporter interface #7795
Conversation
- Corrected arguments passed to get_stories function - Removed an unnecessary import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the new PR!
We also need a changelog entry for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems it's time to convert from draft
to ready for review
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work wrapping this up 💯
Co-authored-by: Tobias Wochinger <t.wochinger@rasa.com>
Proposed changes:
Using the TrainingDataImporter to load the data in core test.
[The current PR is a continuation of this PR where I did something wrong with the commits/rebase/merge and it is quite difficult to clean it up so I created a new PR, the current one, with all changes in a new/clean branch].
Note
It is the proposed solution for the 1st part of this Issue #5986.
The 2nd part was solved from this PR.