Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UnsupportedModelError #7877

Merged
merged 4 commits into from
Feb 7, 2021
Merged

Update UnsupportedModelError #7877

merged 4 commits into from
Feb 7, 2021

Conversation

koaning
Copy link
Contributor

@koaning koaning commented Feb 3, 2021

As small PR for a fix of #7069. The old error message assumes that you're working on a newer Rasa version while this technically isn't always the case. Hence a small change to the error message.

Also, I was slightly scared to rebase because I've never done that before, so I figured it was safer and faster to make a new PR for now. The original PR can be found here.

@koaning
Copy link
Contributor Author

koaning commented Feb 3, 2021

@wochinge I'm surprised to see some tests failing. I'll hit re-run just in case, the failures seem unrelated to this PR.

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please also add a changelog?

@koaning
Copy link
Contributor Author

koaning commented Feb 4, 2021

@wochinge ah yeah forgot about it. Added!

@rasabot rasabot merged commit 78a76e2 into 2.2.x Feb 7, 2021
@rasabot rasabot deleted the fix-issue-7069 branch February 7, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants