New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better data input management for MS botframwork #8190
base: main
Are you sure you want to change the base?
Conversation
Thanks for submitting a pull request 🚀 @b-quachtran will take a look at it as soon as possible ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good @thaume 💯 sorry for the late review
@m-vdb PR fixed following your comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the docstring. I've added a suggesting to fix the failing lint. Could you also take care of the remaining steps from the PR description?
Awesome I've updated the docstring, taking care of the other steps now |
@m-vdb I updated everything, I'm just wondering about the tests : since there are none it seems a bit overkill (and I won't have time right now) to write all the tests for this channel, what do you think ? In terms of documentation, there is no impact, it will just return a correct value everytime. Let me know if you need me to change anything else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the changelog item. I agree with you that the documentation part can be skipped ✅
Regarding the test, asking you to write all the tests is a bit too much for sure 😅 but could you write 3 unit tests that check for the base use case and the ones you introduced?
- postdata contains
text
- postdata doesn't contain
text
but containsvalue
, which in turns containsvalue
- postdata doesn't contain
text
but containsvalue
, which in turns doesn't containvalue
You could take some inspiration from the tests written for the Slack channel.
""" Webhook receiving requests from MS Botframework. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oups, still some whitespaces left here:
""" Webhook receiving requests from MS Botframework. | |
"""Webhook receiving requests from MS Botframework. | |
@thaume following up on this one, do you need help to finalise the PR? |
@m-vdb hey ! I'll never find the time to wrap my head around the test strategy and write them myself. That's the main concern here 🙂 |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Proposed changes:
As discussed in #8164
We have been using this "feature" in production for 2 years now, I felt it was time to share it with everyone else using buttons in Teams' adaptive cards.
It's not a groundbreaking feature but it is very important.
I'll add the tests once we validate that we need this feature here :)
Status (please check what you already did):
black
(please check Readme for instructions)