Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multitenancy #85

Merged
merged 59 commits into from Mar 6, 2017
Merged

Multitenancy #85

merged 59 commits into from Mar 6, 2017

Conversation

amn41
Copy link
Contributor

@amn41 amn41 commented Dec 30, 2016

addresses #36

  • server can serve multiple apps simultaneously, sharing a single nlp instance, if all models are spaCy and in the same language
  • to use, replace server_model_dir in config.json with a json obj, e.g. "server_model_dir":{"one":"model_XXXXX","two":"model_YYYY"} where the keys act as aliases. Then add a model param to HTTP requests, e.g. localhost:5000/parse?q=hello&model=one
  • added documentation explaining how to use
  • added test_multitenancy.py

@vinvinod
Copy link
Contributor

Hi @amn41
I have modified the mitie backend to suppor the multitenancy for rasa.
My MITIE fork is at https://github.com/verloop/MITIE/tree/master
and Rasa fork is at verloop@8073f5d

Let me know what you think about this.

@amn41
Copy link
Contributor Author

amn41 commented Jan 19, 2017

looks cool! I'll check it out. Are there any mitie compatibility issues, e.g. could your branch in principle be merged into MITIE master?

@vinvinod
Copy link
Contributor

Yes, It can be merged into MITIE master.
But I have modified only the named_entity_extractor and text_categorizer classes for taking a total_word_feature_extractor as an input during predicting phase. I have not touched binary_relation_detector.

In the original implementaion of MITIE, get_feature_vector() of total_word_feature_extractor used the same temp variable (to avoid reallocating) for storing intermediate values. But now its allocated freshly for each function call. So these changes might not be suitable for general MITIE users.

@vinvinod
Copy link
Contributor

You can take a look at the relevant PR for MITIE mit-nlp/MITIE#88

@vinvinod
Copy link
Contributor

The PR mit-nlp/MITIE#88 has been accepted. So now we can provide a feature extractor while doing the prediction. Its there for both named_entity_extractor and text_categorizer
I have already made the required changes for mitie interpreter and featurizer.
Its in #149

@tmbo tmbo merged commit f9b6c77 into master Mar 6, 2017
@tmbo tmbo deleted the multitenancy branch March 6, 2017 12:56
@amr-elsehemy
Copy link

Hi I'm currently working on a developing a multi tenant application based on rasa, and I was wondering if there's more thorough documentation for this part available ? @amn41

@YazanMasafah
Copy link

Where I can find the documentation for achieving multi-tenancy?

vcidst pushed a commit that referenced this pull request Jan 23, 2024
* Removed return value as default slot

* added ability to use multiple defaults for cli parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants