Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with forms extracting entities from previous message #8507

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed issue with forms extracting entities from previous message #8507

wants to merge 1 commit into from

Conversation

ivanmkc
Copy link

@ivanmkc ivanmkc commented Apr 20, 2021

Proposed changes:
Fixes: #8505

@ivanmkc ivanmkc force-pushed the imkc--fix-latest-entity-value branch from 5d2936e to 16bb392 Compare April 20, 2021 07:19
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @yennycheung will take a look at it as soon as possible ✨

@yennycheung
Copy link
Contributor

@Imod7, would you have more context for this PR? I saw you were tagged in the original issue.

@Imod7
Copy link
Contributor

Imod7 commented Apr 27, 2021

@yennycheung I only had a quick look at the original Issue but I can now check more in detail the issue and the current PR.

@wochinge wochinge removed the request for review from yennycheung June 4, 2021 11:41
@ancalita ancalita requested review from yennycheung and alwx June 4, 2021 11:41
@stale
Copy link

stale bot commented Apr 16, 2022

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@stale stale bot removed the stale label May 18, 2022
ancalita
ancalita reviewed May 20, 2022
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivanmkc since you submitted this PR, the code in the forms module has gone through some considerable changes to enable the slot mappings feature update in rasa 3.0.
Could you please double-check if the original issue still persists and close the PR if this issue is not applicable anymore? Otherwise if you wish to continue to contribute, pull the recent changes from main and update the PR 🙏🏼

@tmbo tmbo requested a review from a team as a code owner September 12, 2022 19:48
@tmbo tmbo requested review from sanchariGr and removed request for a team September 12, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita left review comments

@sanchariGr sanchariGr Awaiting requested review from sanchariGr sanchariGr was automatically assigned from RasaHQ/atom-squad

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When a form is started, it picks up an entity from the latest user message even when it's not relevant.
5 participants
@ivanmkc @sara-tagger @yennycheung @Imod7 @ancalita