Refactoring test methods

[guilherme-mendes]

Proposed changes:

• Apply clean code and unused imports test_actions.py
• Implements uncouple behaviour from test_count_vectors_featurizer

[sara-tagger]

Thanks for submitting a pull request 🚀 @alopez will take a look at it as soon as possible ✨

[JEM-Mosig]

Hi @guilherme-mendes. Thanks for cleaning this up! I just have a few minor comments.

[guilherme-mendes]

Thanks for the feedback @JEM-Mosig, changes made.

[guilherme-mendes]

Done! @JEM-Mosig @alopez

[JEM-Mosig]

Sorry, @guilherme-mendes I didn't see the message. I typically only see this when you click the re-review arrows and request another review. I'll have a look today :)

[JEM-Mosig]

Almost there. One more thing to do.
Unfortunately I cannot merge main into your repo, so you'll have to do that before we can merge.

[JEM-Mosig]

Please add type annotations for the arguments and return types. Also, our convention is to put descriptions into the function's doc string, i.e.

def get_feature_vectors(sequence: ???, sentence: ???) -> Tuple[Optional[???], Optional[???]]:
  """Retrieves feature vectors from the features.
  
  Args:
    sequence: Features of individual tokens.
    sentence: Features of the entire string.
  
  Returns:
    Feature vectors (or None) for sequence and sentence features.
  """
  ...

You'll have to substitute the right thing for the question marks (just follow the return type of test_message1.get_sparse_features). Sorry I didn't see this earlier.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ guilherme-mendes
❌ itallogravina
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[losterloh]

@guilherme-mendes are you still intending to work on this? 🙂 if yes, please rebase onto main or merge main into your branch and see about all authors signing the CLA, then we're happy to review & approve it!