Don't evaluate entities if no entities present in test data #8813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JEM-Mosig
changed the title
JEM-Mosig
requested review from
federicotdn,
tttthomasssss and
twerkmeister
and removed request for
federicotdn and
tttthomasssss
JEM-Mosig
commented
Jun 7, 2021
twerkmeister
reviewed
Jun 8, 2021
|
@JEM-Mosig Since the original bug resulted in model regression tests failing, did we run model regression tests on this PR to ensure that they don't fail again? |
4 tasks
|
I ran them locally without errors. |
JEM-Mosig
pushed a commit
that referenced
this pull request
Jun 23, 2021
* add fix * Best model checkpoint allows metrics to be equal to previous best if at least one metric improves (#8875) * Best model checkpoint allows metrics to be equal to previous best if at least one metric improves * Apply suggestions from code review Co-authored-by: Sam Sucik <s.sucik@rasa.com> * Fix checkpointing tests * Apply suggestions from code review: formatting, debug cleanup, improved fixture use * security update to tensorflow 2.3.3 * Don't evaluate entities if no entities present in test data (#8813) * Write bugfix * Fix `should_eval_entities` * Update changelog * Pass on density parameter in test * Improve test * prepared release of version 2.7.1 * Remove unneccessary Path casts Co-authored-by: Daksh <d.varshneya@rasa.com> Co-authored-by: koernerfelicia <45405119+koernerfelicia@users.noreply.github.com> Co-authored-by: koernerfelicia <f.koerner@rasa.com> Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
_extract_paired_histogram_specificationraises ValueError when no data is provided #8812Status (please check what you already did):
updated the documentationblack(please check Readme for instructions)