Limit pytest jobs to 1 on CI for Windows and test-nlu-predictors #9733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 28, 2021
Closed
koernerfelicia
changed the title
mprazz
reviewed
Sep 29, 2021
| make ${{ matrix.test }} | ||
|
|
||
| - name: Test Code 🔍 | ||
| if: needs.changes.outputs.backend == 'true' && !(matrix.python-version == 3.8 && matrix.os == 'windows-latest') && !(matrix.os == 'windows-latest' && matrix.test == 'test-nlu-predictors') |
There was a problem hiding this comment.
Suggested change
| if: needs.changes.outputs.backend == 'true' && !(matrix.python-version == 3.8 && matrix.os == 'windows-latest') && !(matrix.os == 'windows-latest' && matrix.test == 'test-nlu-predictors') | |
| if: needs.changes.outputs.backend == 'true' && (matrix.python-version == 3.8 && matrix.os == 'windows-latest') && !(matrix.os == 'windows-latest' && matrix.test == 'test-nlu-predictors') |
I believe you want the opposite condition here no?
There was a problem hiding this comment.
I'm unsure, I was trying to keep the original behaviour: I copied this bit over from the original step and put it into both conditions because I thought we don't want this config ever to run? Or is that not the case anymore?
!(matrix.python-version == 3.8 && matrix.os == 'windows-latest')
There was a problem hiding this comment.
oh sorry, I missed that -- seems we're already not running win + py3.8 at all, indeed. Nevermind me, my bad ahah
Co-authored-by: Mariana Prazeres <m.prazeres@rasa.com>
mprazz
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion here, I'm limiting the pytest jobs to 1 on CI for problematic configurations (Windows +
test-nlu-predictors).This is a temporary fix in order to get TF 2.6 micro out as quickly as possible. I've created a followup issue to investigate and address the memory issues so that the fix can be reverted.