Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

Interactive learning enhancements. Fixes #981 #1088

Merged
merged 21 commits into from
Oct 8, 2018
Merged

Interactive learning enhancements. Fixes #981 #1088

merged 21 commits into from
Oct 8, 2018

Conversation

MetcalfeTom
Copy link
Contributor

@MetcalfeTom MetcalfeTom commented Sep 28, 2018 •
edited
Loading

Proposed changes:

  • Fixes issue #981
  • NLU data learned through the interaction can now be stored in a separate markdown-format file
  • Previous NLU data is merged if it exists
  • Command line interface displays policy confidence alongside the action name

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@MetcalfeTom MetcalfeTom changed the title Log NLU corrections #981 Interactive learning enhancements Sep 28, 2018
@MetcalfeTom MetcalfeTom changed the title Interactive learning enhancements Interactive learning enhancements. Fixes issue #981 Sep 30, 2018
@MetcalfeTom MetcalfeTom changed the title Interactive learning enhancements. Fixes issue #981 Interactive learning enhancements. Fixes #981 Sep 30, 2018
@akelad
Copy link
Contributor

akelad commented Oct 1, 2018

@MetcalfeTom can you resolve the merge conflicts before tom reviews it please?

tmbo
tmbo suggested changes Oct 2, 2018
View reviewed changes
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionality is looking good, couple style comments and suggestions 👍

.gitignore Outdated Show resolved Hide resolved
rasa_core/server.py Outdated Show resolved Hide resolved
rasa_core/training/interactive.py Outdated Show resolved Hide resolved
rasa_core/training/interactive.py Outdated Show resolved Hide resolved
rasa_core/training/interactive.py Outdated Show resolved Hide resolved
rasa_core/training/interactive.py Outdated Show resolved Hide resolved
rasa_core/training/interactive.py Outdated Show resolved Hide resolved
rasa_core/training/interactive.py Outdated Show resolved Hide resolved
rasa_core/training/interactive.py Outdated Show resolved Hide resolved
rasa_core/training/interactive.py Show resolved Hide resolved
@MetcalfeTom MetcalfeTom merged commit 1bc6692 into master Oct 8, 2018
@MetcalfeTom MetcalfeTom deleted the enchanced-cli branch October 8, 2018 14:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tmbo tmbo tmbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MetcalfeTom @akelad @tmbo