This repository has been archived by the owner on Aug 22, 2019. It is now read-only.
Add training date and time to policy metadata when persisting Fixes #1104 #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetcalfeTom
changed the title
ricwo
suggested changes
Oct 2, 2018
| @@ -123,7 +126,8 @@ def _persist_metadata(self, path, dump_flattened_stories=False): | |||
| "python": ".".join([str(s) for s in sys.version_info[:3]]), | |||
| "max_histories": self._max_histories(), | |||
| "ensemble_name": self.__module__ + "." + self.__class__.__name__, | |||
| "policy_names": policy_names | |||
| "policy_names": policy_names, | |||
| "trained_at": self.date_trained | |||
There was a problem hiding this comment.
can we just use the timestamp at persistence time as this happens right after actual training? in some sense the persist() method completes the training. in that case we wouldn't need the self.date_trained attribute
There was a problem hiding this comment.
I'm not sure. I agree that persist completes the training but having it inside the training function ensures that the time is logged as it is described (in case the script in question doesn't follow .train() with .persist() immediately after).
There was a problem hiding this comment.
You're right, but that's very much a special case. either way works, really
ricwo
approved these changes
Oct 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):