This repository has been archived by the owner on Aug 22, 2019. It is now read-only.
In format_bot_output, consider case where data key is present on dict, but None
#1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
When passing an event like `BotUttered("only a text message")` to
`format_bot_output` this will throw as the dict will contain a `data` key,
but its value is `None`. This requires checking for this case before proceeding.
akelad
approved these changes
Nov 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing an event like BotUttered("only a text message") to format_bot_output this will throw as the dict being created will contain a data key, but its value is None. This requires an additional check for this case before proceeding as
getmight as well returnNone.Status (please check what you already did):