Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

fix error with e2e and unseen entities #1521

Merged
merged 5 commits into from
Dec 31, 2018
Merged

fix error with e2e and unseen entities #1521

merged 5 commits into from
Dec 31, 2018

Conversation

EPedrotti
Copy link
Contributor

Proposed changes:

  • check if entity is correctly populated with the "entity" key, if not skips unrecognised entity

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@EPedrotti EPedrotti requested a review from ricwo December 27, 2018 14:31
@CLAassistant
Copy link

CLAassistant commented Dec 27, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ricwo
ricwo approved these changes Dec 28, 2018
View reviewed changes
Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments, otherwise it looks really good!

rasa_core/domain.py Outdated Show resolved Hide resolved
tests/test_evaluation.py Outdated Show resolved Hide resolved
tests/test_evaluation.py Outdated Show resolved Hide resolved
data/test_evaluations/story_unknown_entity.md Outdated Show resolved Hide resolved
@EPedrotti EPedrotti merged commit 5a65c49 into master Dec 31, 2018
@tmbo tmbo deleted the e2e-entity-fix branch March 8, 2019 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ricwo ricwo ricwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@EPedrotti @CLAassistant @ricwo