Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

fix missing enginio dependency #1546

Merged
merged 2 commits into from
Jan 8, 2019
Merged

fix missing enginio dependency #1546

merged 2 commits into from
Jan 8, 2019

Conversation

EPedrotti
Copy link
Contributor

@EPedrotti EPedrotti commented Jan 8, 2019 •
edited
Loading

Proposed changes:

  • re-introduce missing python-engineio (3.0) dependency in requirements.txt and setup.py

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

wochinge
wochinge approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@EPedrotti EPedrotti merged commit c568112 into 0.12.x Jan 8, 2019
@tmbo tmbo deleted the 0.12.x-enginio-fix branch March 8, 2019 12:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@EPedrotti @wochinge