Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

Formbot: small updates on training data #1552

Merged
merged 8 commits into from Jan 10, 2019
Merged

Formbot: small updates on training data #1552

merged 8 commits into from Jan 10, 2019

Conversation

JustinaPetr
Copy link
Contributor

@JustinaPetr JustinaPetr commented Jan 9, 2019

Proposed changes:
I want to reuse this example for the forms tutorial. Without changing too much on the code side, proposing a few improvements on the NLU side and additional intent to make the conversation a bit more natural.

  • A few more examples to NLU training data and added greet intent
  • Updated stories and domain accordingly
  • Added a short readme

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@JustinaPetr JustinaPetr changed the title small updates for training data Formbot: small updates on training data Jan 9, 2019
Copy link
Contributor

@akelad akelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just some minor suggestions

examples/formbot/README.md Outdated Show resolved Hide resolved
examples/formbot/README.md Outdated Show resolved Hide resolved
examples/formbot/README.md Outdated Show resolved Hide resolved
examples/formbot/README.md Outdated Show resolved Hide resolved
examples/formbot/data/stories.md Outdated Show resolved Hide resolved
akelad and others added 5 commits January 10, 2019 09:59
Co-Authored-By: JustinaPetr <juste@rasa.com>
Co-Authored-By: JustinaPetr <juste@rasa.com>
Co-Authored-By: JustinaPetr <juste@rasa.com>
Co-Authored-By: JustinaPetr <juste@rasa.com>
@JustinaPetr JustinaPetr merged commit 70c6bfe into master Jan 10, 2019
@JustinaPetr JustinaPetr deleted the update-formbot branch January 10, 2019 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants