Better creation and handling of facebook buttons #1613
Conversation
fixed pep8 style change adjusted tests
…ve training + added custom facebook button type option
Code Climate has analyzed commit 08afcce and detected 0 issues on this pull request. View more on Code Climate. |
@smn-snkl did you test whether this works? Because I'm just getting error messages from the fbmessenger library. If yes, how did you define the utterances in your domain file? |
@akelad : I think I did back then. Are you sure this PR is right? I couldn't find the relevant lines in this PR:
And I see you're trying to merge patch-2 into master. But in the original PR it's patch-1. |
Oh, sorry. I mixed up these two PRs. Let me check what's going on here. |
@akelad : Two more things though.
What do you think? |
@tmbo what do you think about adding that stuff to the dispatcher? Not sure if it's not a bit too facebook specific |
Maybe we can think of a more generic naming. Most platforms however, support some form of reply suggestions, e.g. Facebook's So some supported format for quick replies in the domain.yml would be super helpful, especially with #1471. Then you could also do something like:
|
Thanks a lot for the added facebook feature 👍 - I'll merge it as it is now, we'll need to refactor the input/output channels a bit more in the coming weeks and we can come up with a better name then |
So far quick reply buttons (e.g. for Facebook) can't really be used efficiently with rasa_core. Also Facebook buttons are forced to type postback, e.g. preventing Login buttons.
Proposed changes:
Changes made by @smn-snkl
Status (please check what you already did):