Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

properly instantiate domain properties #1634

Merged
merged 5 commits into from Jan 25, 2019
Merged

properly instantiate domain properties #1634

merged 5 commits into from Jan 25, 2019

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Jan 25, 2019

Proposed changes:

  • domain was created with invalid properties when dumping from interactive learning which lead to an exception (AttributeError: 'list' object has no attribute 'items')
  • fixes #1194

Status (please check what you already did):

  • made PR ready for code review
  • updated the changelog

@tmbo tmbo requested a review from wochinge January 25, 2019 08:38
@tmbo
Copy link
Member Author

tmbo commented Jan 25, 2019

should be released as part of a minor bug fix release

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CHANGELOG.rst Show resolved Hide resolved
Co-Authored-By: tmbo <tom@rasa.com>
@codeclimate
Copy link

codeclimate bot commented Jan 25, 2019

Code Climate has analyzed commit 0a9c569 and detected 0 issues on this pull request.

View more on Code Climate.

@tmbo tmbo merged commit 029c8ff into master Jan 25, 2019
@tmbo tmbo deleted the fix-domain-persistence branch January 25, 2019 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants