Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

changed slack_channel name specification #1686

Merged
merged 1 commit into from
Feb 5, 2019
Merged

changed slack_channel name specification #1686

merged 1 commit into from
Feb 5, 2019

Conversation

JustinaPetr
Copy link
Contributor

@JustinaPetr JustinaPetr commented Feb 5, 2019 •
edited
Loading

Proposed changes:

  • Changed slack_channel name specification. When channel name is specified as '@channel_name' bot messages don't get posted on a channel. According to Slack Web API the channel should be specified either as a channel id or as a channel name in a form of '#channel_name'.

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@codeclimate
Copy link

codeclimate bot commented Feb 5, 2019

Code Climate has analyzed commit b31a274 and detected 0 issues on this pull request.

View more on Code Climate.

@JustinaPetr JustinaPetr requested a review from tmbo February 5, 2019 16:56
tmbo
tmbo approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@JustinaPetr JustinaPetr merged commit 3cfbad4 into master Feb 5, 2019
@JustinaPetr JustinaPetr deleted the update_slack_connector branch February 5, 2019 22:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tmbo tmbo tmbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@JustinaPetr @tmbo