Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

Checkpoint fix #752

Closed
wants to merge 47 commits into from
Closed

Checkpoint fix #752

wants to merge 47 commits into from

Conversation

Ghostvv
Copy link
Contributor

@Ghostvv Ghostvv commented Jul 16, 2018

Proposed changes:

  • remove redundant generated OR checkpoints even if there are no cycles in the stories
  • remove the whole story step if such redundant generated OR checkpoints were the only checkpoints

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@Ghostvv Ghostvv requested review from tmbo, amn41 and akelad and removed request for tmbo July 16, 2018 13:54
@amn41
Copy link
Contributor

amn41 commented Jul 16, 2018

is master the intended base branch for this? or embedding policy?

@Ghostvv
Copy link
Contributor Author

Ghostvv commented Jul 16, 2018

master, It was branched from embed policy for historic reasons, but I deleted embed policy from this branch and merged master into it

@amn41
Copy link
Contributor

amn41 commented Jul 16, 2018

ok got it - in that case please squash into a single commit

@Ghostvv
Copy link
Contributor Author

Ghostvv commented Jul 16, 2018

did that but how to remove the history of commits above?

@amn41
Copy link
Contributor

amn41 commented Jul 16, 2018

probably have to create a new branch & PR

@Ghostvv Ghostvv closed this Jul 16, 2018
@Ghostvv
Copy link
Contributor Author

Ghostvv commented Jul 16, 2018

#754

@Ghostvv Ghostvv deleted the checkpoint-fix branch July 16, 2018 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants