Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

Predict endpoint #844

Closed
wants to merge 44 commits into from
Closed

Predict endpoint #844

wants to merge 44 commits into from

Conversation

JoeyFaulkner
Copy link
Contributor

@JoeyFaulkner JoeyFaulkner commented Aug 6, 2018

Proposed changes:

  • added a predict endpoint where a list of applied actions can be passed and the next prediction is returned

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@akelad
Copy link
Contributor

akelad commented Aug 6, 2018

great commit messages @JoeyFaulkner hahaha (what is a kebab case)

@tmbo
Copy link
Member

tmbo commented Aug 6, 2018

Something like this is already present in the sdk version: https://github.com/RasaHQ/rasa_core/blob/dispatcher/rasa_core/server.py#L317

@JoeyFaulkner
Copy link
Contributor Author

@tmbo No, this is a predict endpoint where you can pass any collection of events, it doesnt need to be tied to a particular sender

@tmbo
Copy link
Member

tmbo commented Aug 6, 2018

ah alright, makes sense 👍 - can you please rebase from master or do you need any changes made on the sdk branch?

@JoeyFaulkner JoeyFaulkner requested a review from tmbo August 8, 2018 08:30
@tmbo
Copy link
Member

tmbo commented Aug 8, 2018

This is still pulling in the changes from the event output branch. I am not sure what happened in the commit history there in the middle

bildschirmfoto 2018-08-08 um 10 44 46

but it wasn't straightforward to rebase and you'd probably need to cherry pick your changes. Given that the changes are split across 40 commits I'd rather suggest you create a new branch and only apply the changes you want in the PR there.

@JoeyFaulkner
Copy link
Contributor Author

@tmbo ok will do!

@JoeyFaulkner JoeyFaulkner deleted the predict_endpoint branch August 8, 2018 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants