Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

add EmbeddingPolicy to changelog #936

Merged
merged 3 commits into from
Sep 4, 2018
Merged

add EmbeddingPolicy to changelog #936

merged 3 commits into from
Sep 4, 2018

Conversation

Ghostvv
Copy link
Contributor

@Ghostvv Ghostvv commented Sep 4, 2018

Proposed changes:

  • modified changelog

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@Ghostvv Ghostvv requested a review from tmbo September 4, 2018 12:57
tmbo
tmbo approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also link to the place in the docs using

:ref:Embedding policy

@tmbo tmbo merged commit 472fc3e into master Sep 4, 2018
@tmbo tmbo deleted the embed_changelog branch September 4, 2018 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tmbo tmbo tmbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Ghostvv @tmbo