This repository has been archived by the owner on Aug 22, 2019. It is now read-only.
added socketio channel implementation #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akelad
approved these changes
Sep 13, 2018
| def __init__(self, | ||
| user_message_evt="user_uttered", # type: Text | ||
| bot_message_evt="bot_uttered", # type: Text | ||
| namespace=None # type: Optional[Text] |
There was a problem hiding this comment.
what's this namespace for? if we're reading it from the credentials file it should also be explained in the docs right?
There was a problem hiding this comment.
no clue :D didn't read the socket io docs - but i think it allows you to use the same message names in different contexts. don't think it is important though.
rasa_core/channels/socketio.py
Outdated
| def connect(sid, environ): | ||
| logger.debug("User {} connected to socketio endpoint.".format(sid)) | ||
|
|
||
| @sio.on('disconnect', namespace=self.name()) |
There was a problem hiding this comment.
why is this self.name() and the connect one above self.namespace?
There was a problem hiding this comment.
good spot, should be namespace as well 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):