Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix emoji errors with regex patterns #1612

Merged
merged 1 commit into from Jan 10, 2019
Merged

fix emoji errors with regex patterns #1612

merged 1 commit into from Jan 10, 2019

Conversation

wochinge
Copy link
Contributor

Proposed changes:

  • try parsing it as usual and apply emoji fixes only in case of a `ScannerError``
  • add more test cases

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • [ ] updated the documentation
  • [ ] updated the changelog (already included in changelog)

Copy link
Contributor

@MetcalfeTom MetcalfeTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

  • Tested emoji 💯
  • Tested reading from a yaml file 📃

Works fine on my end. Thanks for firefighting on this one 👨‍🚒

@wochinge wochinge merged commit 2636bf7 into master Jan 10, 2019
@wochinge wochinge deleted the emoji_fix2 branch January 10, 2019 09:54
taytzehao pushed a commit to taytzehao/rasa that referenced this pull request Jul 14, 2023
…asaHQ#1612)

Bumps [github.com/go-git/go-billy/v5](https://github.com/go-git/go-billy) from 5.4.0 to 5.4.1.
- [Release notes](https://github.com/go-git/go-billy/releases)
- [Commits](go-git/go-billy@v5.4.0...v5.4.1)

---
updated-dependencies:
- dependency-name: github.com/go-git/go-billy/v5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants