Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap component order #1776

Merged
merged 3 commits into from
Mar 14, 2019
Merged

Swap component order #1776

merged 3 commits into from
Mar 14, 2019

Conversation

MetcalfeTom
Copy link
Contributor

@MetcalfeTom MetcalfeTom commented Mar 12, 2019

Fixes #1744

Proposed changes:

  • Pretrained pipeline in docs was not consistent with the order in registry.py, now it is

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@codeclimate
Copy link

codeclimate bot commented Mar 12, 2019

Code Climate has analyzed commit 4713b8c and detected 0 issues on this pull request.

View more on Code Climate.

@MetcalfeTom MetcalfeTom added the type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones. label Mar 12, 2019
@MetcalfeTom MetcalfeTom requested a review from akelad March 12, 2019 10:06
@MetcalfeTom MetcalfeTom merged commit 2486052 into master Mar 14, 2019
@MetcalfeTom MetcalfeTom deleted the pipeline-doc-typo branch March 14, 2019 14:03
tmbo added a commit that referenced this pull request Mar 21, 2019
Set default log file encoding to utf-8 for #1776
taytzehao pushed a commit to taytzehao/rasa that referenced this pull request Jul 14, 2023
* feat: implement steps.timeout-minutes

* Add imports

* refactor code

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants