Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove number of samples from categorical shapes #39

Closed
Tracked by #53
ri-heme opened this issue Oct 10, 2022 · 0 comments · Fixed by #56
Closed
Tracked by #53

Remove number of samples from categorical shapes #39

ri-heme opened this issue Oct 10, 2022 · 0 comments · Fixed by #56
Assignees
@valentas1 @ri-heme
Labels
refactoring Improve code structure or implementation without affecting functionality

Comments

@ri-heme
Copy link
Collaborator

ri-heme commented Oct 10, 2022

MOVEDataset stores categorical_shapes and continuous_shapes. The former is a list of tuples containing three numbers: number of samples, number of features, number of categories per feature. The first item is not needed, and it is inconsistent with continuous_shapes (which does not store the number of samples, but only number of features).

Several functions will be affected by this change.
@ri-heme ri-heme self-assigned this Oct 10, 2022
@ri-heme ri-heme added the refactoring Improve code structure or implementation without affecting functionality label Oct 10, 2022
@valentas1 valentas1 self-assigned this Nov 7, 2022
@ri-heme ri-heme mentioned this issue Nov 9, 2022
Closed
3 tasks
@ri-heme ri-heme mentioned this issue Nov 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentas1 valentas1

@ri-heme ri-heme

Labels
refactoring Improve code structure or implementation without affecting functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🧹 Clean-up RasmussenLab/MOVE
2 participants
@valentas1 @ri-heme